feat(cdp): App metrics #23893

benjackwhite · 2024-07-22T16:04:11Z

Problem

We needed a different table for app metrics - now we have one, lets use it.

Changes

Writes the data to the app metrics table
Adds a new view for displaying it
Add to sparkline

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

mariusandra

Looks great!

There's just some UX quirk where it opens the wrong link if I click on things in the right order:

Some combination of opening the metrics tab and clicking back "locks" the previously open destination in place somehow.

# Conflicts: # frontend/src/types.ts

benjackwhite · 2024-07-23T08:27:56Z

There's just some UX quirk where it opens the wrong link if I click on things in the right order:

Yeah iirc this was already an issue. I'll try and fix it now as follow up. Likely some logic that isn't getting unmounted

posthog-bot · 2024-07-23T09:06:26Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

github-actions · 2024-07-23T09:16:22Z

Size Change: +225 B (+0.02%)

Total Size: 1.07 MB

ℹ️ View Unchanged

Filename	Size	Change
`frontend/dist/toolbar.js`	1.07 MB	+225 B (+0.02%)

_{compressed-size-action}

posthog-bot · 2024-07-23T09:24:56Z

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

…-metrics

…ithub.com:PostHog/posthog into feat/cdp-app-metrics # Conflicts: # frontend/__snapshots__/scenes-app-dashboards--insight-legend--dark.png

posthog-bot · 2024-07-23T11:41:15Z

📸 UI snapshots have been updated

3 snapshot changes in total. 0 added, 3 modified, 0 deleted:

chromium: 0 added, 3 modified, 0 deleted (diff for shard 1)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-07-23T12:19:07Z

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

# Conflicts: # frontend/__snapshots__/scenes-app-dashboards--insight-legend--dark.png

posthog-bot · 2024-07-23T13:00:04Z

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-07-23T13:19:33Z

📸 UI snapshots have been updated

3 snapshot changes in total. 0 added, 3 modified, 0 deleted:

chromium: 0 added, 3 modified, 0 deleted (diff for shard 1, diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-07-23T13:39:05Z

📸 UI snapshots have been updated

3 snapshot changes in total. 0 added, 3 modified, 0 deleted:

chromium: 0 added, 3 modified, 0 deleted (diff for shard 1, diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-07-23T13:57:25Z

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-07-23T14:16:46Z

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

chromium: 0 added, 2 modified, 0 deleted (diff for shard 1, diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-07-23T14:35:52Z

📸 UI snapshots have been updated

3 snapshot changes in total. 0 added, 3 modified, 0 deleted:

chromium: 0 added, 3 modified, 0 deleted (diff for shard 1, diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

…o feat/cdp-app-metrics

posthog-bot · 2024-07-23T16:01:51Z

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

benjackwhite added 6 commits July 22, 2024 11:58

Added log metrics all over the place

fac3a13

Fix up metrics

7b9ec81

Fixes

4ba12fa

Fixes

bd965a4

Fix up label generation

bd093c5

Fixes

246fba4

benjackwhite requested review from bretthoerner and mariusandra July 23, 2024 07:23

benjackwhite added 2 commits July 23, 2024 09:38

Added to spark lines

0695755

Fixes

4c4a54e

mariusandra approved these changes Jul 23, 2024

View reviewed changes

benjackwhite added 4 commits July 23, 2024 10:07

Added tooltipFixes

bc59991

Fixes

e677250

Merge branch 'master' into feat/cdp-app-metrics

d66fe51

# Conflicts: # frontend/src/types.ts

Fix

2dae006

benjackwhite and others added 4 commits July 23, 2024 10:41

Fix tests

38d67c9

fix

79e559b

Fix urls

6482fc4

Update UI snapshots for chromium (1)

8043dd6

Update UI snapshots for chromium (1)

1160d58

benjackwhite added 2 commits July 23, 2024 13:22

Merge branch 'master' of github.com:PostHog/posthog into feat/cdp-app…

b944f78

…-metrics

Merge branches 'feat/cdp-app-metrics' and 'feat/cdp-app-metrics' of g…

0eab788

…ithub.com:PostHog/posthog into feat/cdp-app-metrics # Conflicts: # frontend/__snapshots__/scenes-app-dashboards--insight-legend--dark.png

benjackwhite mentioned this pull request Jul 23, 2024

Hog CDP Megaissue #22833

Open

61 tasks

benjackwhite enabled auto-merge (squash) July 23, 2024 11:29

Update UI snapshots for chromium (1)

91a8f56

Update UI snapshots for chromium (1)

a2cb741

benjackwhite added 3 commits July 23, 2024 14:42

Merge branch 'master' into feat/cdp-app-metrics

b8d10a8

# Conflicts: # frontend/__snapshots__/scenes-app-dashboards--insight-legend--dark.png

Removed instance_id

a5c2817

Fix

28ca47b

benjackwhite requested a review from bretthoerner July 23, 2024 12:45

Update UI snapshots for chromium (1)

75de822

Update UI snapshots for chromium (1)

26bc69e

bretthoerner approved these changes Jul 23, 2024

View reviewed changes

Update UI snapshots for chromium (2)

c5ca1f8

github-actions bot added 2 commits July 23, 2024 13:36

Update UI snapshots for chromium (1)

243e65f

Update UI snapshots for chromium (2)

97eb657

Update UI snapshots for chromium (1)

9876bdd

github-actions bot added 2 commits July 23, 2024 14:14

Update UI snapshots for chromium (1)

ce4dd21

Update UI snapshots for chromium (2)

2962e1e

github-actions bot added 2 commits July 23, 2024 14:34

Update UI snapshots for chromium (1)

72b35d3

Update UI snapshots for chromium (2)

221a335

benjackwhite and others added 3 commits July 23, 2024 17:43

Merge branch 'master' into feat/cdp-app-metrics

62202a5

Merge branch 'feat/cdp-app-metrics' of github.com:PostHog/posthog int…

1eda3de

…o feat/cdp-app-metrics

Update UI snapshots for chromium (1)

8c8f25b

benjackwhite merged commit 1ff75d7 into master Jul 23, 2024
90 checks passed

benjackwhite deleted the feat/cdp-app-metrics branch July 23, 2024 16:16

silentninja pushed a commit to silentninja/posthog that referenced this pull request Aug 8, 2024

feat(cdp): App metrics (PostHog#23893)

9b7b4a9

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(cdp): App metrics #23893

feat(cdp): App metrics #23893

benjackwhite commented Jul 22, 2024 •

edited

Loading

mariusandra left a comment

benjackwhite commented Jul 23, 2024

posthog-bot commented Jul 23, 2024

github-actions bot commented Jul 23, 2024 •

edited

Loading

posthog-bot commented Jul 23, 2024

posthog-bot commented Jul 23, 2024

posthog-bot commented Jul 23, 2024

posthog-bot commented Jul 23, 2024

posthog-bot commented Jul 23, 2024

posthog-bot commented Jul 23, 2024

posthog-bot commented Jul 23, 2024

posthog-bot commented Jul 23, 2024

posthog-bot commented Jul 23, 2024

posthog-bot commented Jul 23, 2024

feat(cdp): App metrics #23893

feat(cdp): App metrics #23893

Conversation

benjackwhite commented Jul 22, 2024 • edited Loading

Problem

Changes

Does this work well for both Cloud and self-hosted?

How did you test this code?

mariusandra left a comment

Choose a reason for hiding this comment

benjackwhite commented Jul 23, 2024

posthog-bot commented Jul 23, 2024

📸 UI snapshots have been updated

github-actions bot commented Jul 23, 2024 • edited Loading

posthog-bot commented Jul 23, 2024

📸 UI snapshots have been updated

posthog-bot commented Jul 23, 2024

📸 UI snapshots have been updated

posthog-bot commented Jul 23, 2024

📸 UI snapshots have been updated

posthog-bot commented Jul 23, 2024

📸 UI snapshots have been updated

posthog-bot commented Jul 23, 2024

📸 UI snapshots have been updated

posthog-bot commented Jul 23, 2024

📸 UI snapshots have been updated

posthog-bot commented Jul 23, 2024

📸 UI snapshots have been updated

posthog-bot commented Jul 23, 2024

📸 UI snapshots have been updated

posthog-bot commented Jul 23, 2024

📸 UI snapshots have been updated

posthog-bot commented Jul 23, 2024

📸 UI snapshots have been updated

benjackwhite commented Jul 22, 2024 •

edited

Loading

github-actions bot commented Jul 23, 2024 •

edited

Loading